Remove hard deps on certifi and chardet
augustozanellato opened this issue · 5 comments
augustozanellato commented
Hi,
In the project's requirements.txt
there are hard dependencies on certifi
and chardet
on some old versions, those packages aren't used anywhere in the library, they're just indirect dependencies and are probably in requirements.txt because someone did a pip freeze
.
At a quick glance a correct requirements.txt
for this project would just be:
requests>=2.25.1
six>=1.15.0
typing>=3.7.4.3
pablo commented
Awesome,
Will take a look and update requirements.txt file.
Thanks!
…On Mon, Sep 19, 2022 at 11:02 AM Augusto Zanellato ***@***.***> wrote:
Hi,
In the project's requirements.txt there are hard dependencies on certifi
and chardet on some old versions, those packages aren't used anywhere in
the library, they're just indirect dependencies and are probably in
requirements.txt because someone did a pip freeze.
At a quick glance a correct requirements.txt for this project would just
be:
requests>=2.25.1
six>=1.15.0
typing>=3.7.4.3
—
Reply to this email directly, view it on GitHub
<#43>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIUGHAASC27LSZQXC4RBADV7B6ALANCNFSM6AAAAAAQQGGF5M>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
mkotek commented
Implemented, so most likely the issue can be closed.
augustozanellato commented
Implemented, so most likely the issue can be closed.
I don't see the needed changes on master branch.
EDIT: the wheel uploaded to PyPI for version 1.1.4 also doesn't have the fix
dopstar commented
@augustozanellato addressed this on this pr:
- #45
pypi release 1.1.5 should be available within 10 min from now
augustozanellato commented
Thanks ^_^