paed01/bpmn-engine

Removing wrong event listener in the case of an error.

Closed this issue · 3 comments

allain commented

Hello. I was reading the code and realise that it should be removing the event listener for onEvent rather than onError.

bpmn-engine/index.js

Line 249 in fef68c6

engine.removeListener(eventName, onError);

paed01 commented

You are absolutely right! Silly mistake.

allain commented

No problem. Want me to PR?

paed01 commented

@allain your version is published. I added some tests to make sure it won't happen again.

  • 👍1