'numadd', `numsub` are not valid accelerators - but they are

[Nantris]

I'm using this as a reference: https://electronjs.org/docs/api/accelerator

All of the below hotkeys should work in theory and I have confirmed that esc and numadd function as intended when registering directly with electron

Errors listed below. Thank you very, very much for this awesome library. It patches a weakness in Electron and makes development a lot more pleasant.

WARNING: esc is not a valid accelerator.

    at Array.forEach (<anonymous>)
    at createSecondaryMenu (webpack:///./app/desktop/main/secondaryWindow.js?:148:76)
    at createMainWindow (webpack:///./app/desktop/main/createMainWindow.js?:89:74)


WARNING: numadd is not a valid accelerator.

    at Array.forEach (<anonymous>)
    at createSecondaryMenu (webpack:///./app/desktop/main/secondaryWindow.js?:148:76)
    at createMainWindow (webpack:///./app/desktop/main/createMainWindow.js?:89:74)

17:27:43.999 > Error: Unvalid keycode `u`.
    at reduceKey (webpack:///./node_modules/keyboardevent-from-electron-accelerator/index.js?:186:9)
    at toKeyEvent (webpack:///./node_modules/keyboardevent-from-electron-accelerator/index.js?:274:14)
    at Object.register (webpack:///./node_modules/electron-localshortcut/index.js?:224:21)
    at eval (webpack:///./app/desktop/main/secondaryWindow.js?:150:29)
    at Array.forEach (<anonymous>)
    at createSecondaryMenu (webpack:///./app/desktop/main/secondaryWindow.js?:148:76)
    at createMainWindow (webpack:///./app/desktop/main/createMainWindow.js?:89:74)

WARNING: shift+- is not a valid accelerator.

    at Array.forEach (<anonymous>)
    at createSecondaryMenu (webpack:///./app/desktop/main/secondaryWindow.js?:148:76)
    at createMainWindow (webpack:///./app/desktop/main/createMainWindow.js?:89:74)


WARNING: shift+numadd is not a valid accelerator.

    at Array.forEach (<anonymous>)
    at createSecondaryMenu (webpack:///./app/desktop/main/secondaryWindow.js?:148:76)
    at createMainWindow (webpack:///./app/desktop/main/createMainWindow.js?:89:74)

17:27:44.023 > Error: Unvalid keycode `u`.
    at reduceKey (webpack:///./node_modules/keyboardevent-from-electron-accelerator/index.js?:186:9)
    at toKeyEvent (webpack:///./node_modules/keyboardevent-from-electron-accelerator/index.js?:274:14)
    at Object.register (webpack:///./node_modules/electron-localshortcut/index.js?:224:21)
    at eval (webpack:///./app/desktop/main/secondaryWindow.js?:150:29)
    at Array.forEach (<anonymous>)
    at createSecondaryMenu (webpack:///./app/desktop/main/secondaryWindow.js?:148:76)
    at createMainWindow (webpack:///./app/desktop/main/createMainWindow.js?:89:74)

WARNING: ctrl+- is not a valid accelerator.

    at Array.forEach (<anonymous>)
    at createSecondaryMenu (webpack:///./app/desktop/main/secondaryWindow.js?:148:76)
    at createMainWindow (webpack:///./app/desktop/main/createMainWindow.js?:89:74)


WARNING: ctrl+numadd is not a valid accelerator.

    at Array.forEach (<anonymous>)
    at createSecondaryMenu (webpack:///./app/desktop/main/secondaryWindow.js?:148:76)
    at createMainWindow (webpack:///./app/desktop/main/createMainWindow.js?:89:74)

17:27:44.032 > Error: Unvalid keycode `u`.
    at reduceKey (webpack:///./node_modules/keyboardevent-from-electron-accelerator/index.js?:186:9)
    at toKeyEvent (webpack:///./node_modules/keyboardevent-from-electron-accelerator/index.js?:274:14)
    at Object.register (webpack:///./node_modules/electron-localshortcut/index.js?:224:21)
    at eval (webpack:///./app/desktop/main/secondaryWindow.js?:150:29)
    at Array.forEach (<anonymous>)
    at createSecondaryMenu (webpack:///./app/desktop/main/secondaryWindow.js?:148:76)
    at createMainWindow (webpack:///./app/desktop/main/createMainWindow.js?:89:74)

[slapbox]

I just realized that my log was for a slightly different configuration where I tried ctrl+- instead of ctrl+numsub.

Not shown in the logs above, ctrl+numsub fails the same way ctrl+numadd does.

[slapbox]

Here's a full list of the hotkeys we're trying to register:

const toRegister = [
  'numsub',
  'numadd',
  'shift+numsub',
  'shift+numadd',
  'ctrl+numsub',
  'ctrl+numadd',
];

esc works properly despite saying it's invalid like #95

[slapbox]

ctrl+- seems to work but ctrl+numsub fails.

ctrl++ and ctrl+numadd both fail.