peterpaulis/StaticDataTableViewController

Carthage support

igorkulman opened this issue · 9 comments

igorkulman commented

Any chance you can add Carthage support? It probably only requires adding a shared target with StaticDataTableViewController.h and StaticDataTableViewController.m.

peterpaulis commented

Hi, thanks, going to look into Carthage support

peterpaulis commented

try the 2.5.1

igorkulman commented 
*** Checking out StaticDataTableViewController at "2.5.1"
*** xcodebuild output can be found in /var/folders/bt/ckwd2h017zd6hl4gnnfhxrv80000gn/T/carthage-xcodebuild.KPsJ9S.log
*** Skipped building StaticDataTableViewController due to the error:
Dependency "StaticDataTableViewController" has no shared framework schemes for any of the platforms: iOS
peterpaulis commented

Hi, try now, there was one uncommitted file... i also removed the codesign for the framework

igorkulman commented 
Build settings from command line:
    CARTHAGE = YES
    CODE_SIGN_IDENTITY = 
    CODE_SIGNING_REQUIRED = NO
    ONLY_ACTIVE_ARCH = NO
    SDKROOT = iphonesimulator11.2

NOTE: Xcode project 'StaticDataTableViewControllerFramework' was written by a newer Xcode version (50) -- temporarily downgrading it (without modifying project file)

xcodebuild: error: Unable to find a destination matching the provided destination specifier:
		{ platform:iOS Simulator, id:F17BD914-594F-401E-AAC8-1FBDFB7AA848 }

	Ineligible destinations for the "Framework" scheme:
		{ platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Generic iOS Device }
		{ platform:iOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-iphonesimulator:placeholder, name:Generic iOS Simulator Device }
igorkulman commented

But no need to fix this, I am using https://github.com/muyexi/StaticTableViewController instead, it works with Carthage just fine.

peterpaulis commented

hmm strange, looks fine when i test with "carthage build --no-skip-current"

Peters-iMac:StaticDataTableViewController admin$ carthage build --no-skip-current
*** xcodebuild output can be found in /var/folders/kl/00fl4tx954j4s9f6z9z769bw0000gn/T/carthage-xcodebuild.sRXqmQ.log
*** Building scheme "Framework" in StaticDataTableViewController.xcworkspace
Peters-iMac:StaticDataTableViewController admin$

if you know how to improve it in a better way, feel free to contribute and push a commit, i am not a Carthage user unfortunately

igorkulman commented

I figured it out. The problem is that I am stuck with Xcode 9.2 because of some 3rd party stuff I do not have control over and your framework project file says 9.3 so it cannot be built on my machine.

peterpaulis commented

so i assume all ok and closing this one