Debugger instead of dialog when extracting a method

[jecisc]

If you try to extract a method that cannot be extracted, you currently will get a debugger instead of a dialog explaining the problem.

To reproduce add this method:

aMethod
	|  test |
	test := 1.
	1 to: 10 do: [ test := 2 ].
	test := 4.
	self flag: #todo.

Then try to extract

1 to: 10 do: [ test := 2 ].
	test := 4.
	self flag: #todo.

@tesonep

[dionisiydk]

It is fixed but not integrated. Commander is still old image. Iceberg update will fix it ср, 9 янв. 2019 г., 13:15 CyrilFerlicot notifications@github.com:

…

If you try to extract a method that cannot be extracted, you currently will get a debugger instead of a dialog explaining the problem. To reproduce add this method: aMethod | test | test := 1. 1 to: 10 do: [ test := 2 ]. test := 4. self flag: #todo. ``` Then try to extract ``` 1 to: 10 do: [ test := 2 ]. test := 4. self flag: #todo. ``` @tesonep — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#415>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHxaoL18p3iL-b5E5E7oeRAdhx_-7NqRks5vBetrgaJpZM4Z3dak> .

[tesonep]

The error is still present in the latest calypso with latest Commander.
The execution of the refactorings is completly different in this scenario.

[dionisiydk]

Such cases should be fixed on pharo side. Refactorings should raise RefactoringError's instead of basic Error ср, 9 янв. 2019 г., 13:52 Pablo Tesone notifications@github.com:

…

The error is still present in the latest calypso with latest Commander. The execution of the refactorings is completly different in this scenario. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#415 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHxaoEjDIZK4dZKNSXxbVoT0TGwiWlV8ks5vBfQrgaJpZM4Z3dak> .