phenopackets/phenopacket-tools

BiosampleConverter

pnrobinson opened this issue · 1 comments

@julesjacobsen given the lack of strictness in the semantics of version 1 variants, it seems it might be better to emit a warning here that the user will need an implementation specific way of doing this conversion?

if (biosample.getVariantsCount() != 0) {
     // TODO: create an interpretation along with any genes
}

@ielis @julesjacobsen -- we could add this to the conversion and basically just assume that it is causal if people used it in V1 or we could emit a warning and skip things. Thoughts?