Why not send JSON object on data event than a string which needs parsing?

Question

Why not send JSON object on data event than a string which needs parsing?

Closed this issue 11 years ago · 3 comments

elasticSearchClient.index(indexName, objName, {'name':'name', id:"1111"})
                .on('data', function(data) { // <- why can't the data be a JSON object?

                })
                .exec();

Answer 1 · 2012-12-30T21:48:32.000Z

That would have been better, but for the moment I'd rather not break anything that expects a string.

Answer 2 · 2013-09-10T14:59:31.000Z

@phillro, if I submitted a PR to introduce a parseJson parameter into the server options, having it default to false for 0.5.x branch and then changing the default to true for 0.6.x - would you accept that?

Answer 3 · 2013-09-10T15:14:00.000Z

Sure. Reason I did not default this was performance as I was often just
handing the data off.
On Sep 10, 2013 11:00 AM, "Eric Caron" notifications@github.com wrote:

@phillro https://github.com/phillro, if I submitted a PR to introduce a
parseJson parameter into the server options, having it default to falsefor 0.5.x branch and then changing the default to
true for 0.6.x - would you accept that?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-24166672
.