Use of -r when making binutils
harrysarson opened this issue · 4 comments
On this line of the Makefile we pass -r to make.
The -r argument is documented as follows
‘-r’
‘--no-builtin-rules’Eliminate use of the built-in implicit rules (see Using Implicit Rules). You can still define your own by writing pattern rules (see Defining and Redefining Pattern Rules). The ‘-r’ option also clears out the default list of suffixes for suffix rules (see Old-Fashioned Suffix Rules). But you can still define your own suffixes with a rule for .SUFFIXES, and then define your own suffix rules. Note that only rules are affected by the -r option; default variables remain in effect (see Variables Used by Implicit Rules); see the ‘-R’ option below.
The build issues mentioned in #18 (comment) and #18 (comment) are fixed if I remove the flag.
@phillipstanleymarbell do you know why the -r flag was added?
At some point, on some platform, that was necessary. I'm happy to merge the change. Ideally someone would test on macOS (I'm assuming you're on Linux and I know @samuelmswong is testing on Linux).
Let's merge your suggestion anyway.
Makes sense 👍
Changes are included in #18
Closing as #18 is merged 🎉