pimterry/loglevel

Support `loglevel.getLogger(Symbol())`

vvanpo opened this issue · 4 comments

vvanpo commented

Passing a string to getLogger does not ensure that your logger won't collide with existing loggers, leading to unexpected behaviour. In tests or for libraries that don't know much about what environment they're running in, it can be helpful to use Symbol to ensure there can never be collisions.

pimterry commented

Great suggestion! I've added support for that in ae3a282.

The one tricky bit is that we previously used names for log level persistence: in a browser, the level for each logger is stored as loglevel:${logname} in local storage. We can't uniquely do that for symbols, so I've just dropped persistence for symbol-named loggers entirely, we effectively treat them as fresh every time. Can you take a look at at that, and let me know if that would work for you?

vvanpo commented

Thanks for the quick turnaround! And yes, that definitely works for me.

dixdiydiz commented

@pimterry
index.d.ts should fix:
getLogger(name: string): Logger;
to
getLogger(name: string | symbol): Logger;

pimterry commented

Good catch, thanks @dixdiydiz! Now fixed in v1.7.1.

In future do feel free to throw in a PR, I'm very happy to merge tiny fixes like that straight away.