pixelsign/html5-device-mockups

iPhone X missing in NPM install

Opened this issue · 11 comments

julianctni commented

I installed your library via npm, but it seems that there I do not get the most current version? The iPhone X is missing. :( Would be nice to get a npm update!

MateoWartelle commented

Yes, agreed.

pronkman commented

Installed via Bower – also missing iPhone X.

pronkman commented

The src folder with scss files is also missing from the installation.

zilahir commented

@pronkman

i have forked this repo, and created a new release, now the iPhone X also avaliable.

  • 👍3
jpswade commented

@pixelsign is there any reason we can't tag the latest version?

pixelsign commented

Hey all, there were some people helping with this but since then they are not able anymore to contribute. If anyone of you is willing to help please do, because my technical knowledge is limited. Happy to merge any good requests

pixelsign commented
jpswade commented

The latest release has a tag however it shows as not verified
…
On Tue, Jul 7, 2020 at 11:16 AM James Wade @.***> wrote: @pixelsign https://github.com/pixelsign happy to help, all you need to do is tag a release... See https://docs.github.com/en/github/administering-a-repository/managing-releases-in-a-repository — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#74 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALJ6JITE7JHQ64DID6QX2TR2LKXDANCNFSM4GX6C5EA .
-- Angelos Arnis Strategic Designer +358 (0) 45 8498340 Resumé http://fi.linkedin.com/in/angelosarnis | Portfolio http://arn.is

No that's not it at all. The latest commit is e5a38fc, the latest release (3.2.1) says the commit is b0ba1b1, back in 7 Mar 2018. You need to create a new tag with each release.

pixelsign commented
  • 😕1
abbaty48 commented

IPhoneX and some are still missing in version 3.2.1