pkleczko/CustomGauge

Error in mPointStart

Closed this issue · 4 comments

mPointSize is using a.getColor(R.styleable.CustomGauge_pointSize,0) instead of a.getInt(R.styleable.CustomGauge_pointSize,0) because of which it was giving errors. Should it be getColor or getInt ?

As I remember getColor is correct. Can you copy+paste this error?

Pawel

Pozdrawiam, Best regards,

Paweł Kleczkowski | Freelancer - Mobile Developer

mobile +48 669 934 133
email contact@pawelkleczkowski.pl emil@netmart.pl
skype pkleczko

Rozwiązania Informatyczne dla Biznesu - Paweł Kleczkowski
03-556 Warszawa, ul. Handlowa 34/17
www.pawelkleczkowski.pl

2015-06-23 10:23 GMT+02:00 Ravi Shenoy notifications@github.com:

mPointSize is using a.getColor(R.styleable.CustomGauge_pointSize,0)
instead of a.getInt(R.styleable.CustomGauge_pointSize,0) because of which
it was giving errors. Should it be getColor or getInt ?


Reply to this email directly or view it on GitHub
#1.

Why should it be getColor() ? The pointSize in xml is setting the point size, an int and the parser is just setting to mPointSize. Color is set separately, isnt it ?

Oh, yes, it's mPointSize (size). You're probably right. In fact I
remembered this code had worked for me, but maybe I made some changes and
didn't verify them. If it works for you with getInt it's a bug.

Pozdrawiam, Best regards,

Paweł Kleczkowski | Freelancer - Mobile Developer

mobile +48 669 934 133
email contact@pawelkleczkowski.pl emil@netmart.pl
skype pkleczko

Rozwiązania Informatyczne dla Biznesu - Paweł Kleczkowski
03-556 Warszawa, ul. Handlowa 34/17
www.pawelkleczkowski.pl

2015-06-23 11:46 GMT+02:00 Ravi Shenoy notifications@github.com:

Why should it be getColor() ? The pointSize in xml is setting the point
size, an int and the parser is just setting to mPointSize. Color is set
separately, isnt it ?


Reply to this email directly or view it on GitHub
#1 (comment).

Thanks for the response. getColor will also work, because getColor also takes Int and returns Int. But it might return a size (some enum corresponding to the input value) it might NOT be the size that app wants.