Division arithmetic helper does not exists

[umer-mehmood]

Hello, we have a use case, in which we have to divide a column with an integer value. To do that I am not able to find any arithmetic helper. There exists two for addition and multiplication, but we also have to apply division operation on a column.

Example: Select * from column1 * 1, column2 / 2 from Table

Kindly let me know if there is any way to achieve this. Thanks

[planetarydev]

Yes, if you want you can contribute and add a $div helper by yourself.
As template you could easily use the $mul helper. After adding the div directory, adding the source-file div.js with tests please run npm test and the readme will be generated automatcally after a successful test-run.

Here is the location of the mul helper:
https://github.com/planetarydev/json-sql-builder2/tree/master/sql/helpers/arithmetic/mul

[planetarydev]

sorry, I dont want to close :-) ... hm, reopend again ...
If you got further questions please let me know

[umer-mehmood]

Hello, I have implemented the $div helper and tested it. The documentation file is also added along with the readme file. Kindly can you give access of the repository, so that i can push the feature branch and create a pull request for master branch. Regards, Umer Mehmood NorthBay Direct: +92 3234971359 umer.mahmood@northbaysolutions.net <faheem.khan@northbaysolutions.net> www.Northbaysolutions.com <http://www.northbaysolutions.com/>

…

On Thu, Nov 7, 2019 at 1:27 PM Planetary Development < ***@***.***> wrote: Reopened #23 <#23> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23?email_source=notifications&email_token=AMMDKPDMKEBRPQWARPFRIJ3QSPGPZA5CNFSM4JJT7T3KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUWM7WUA#event-2778331984>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMMDKPFHP5NVON3TIX4Z2Y3QSPGPZANCNFSM4JJT7T3A> .

[planetarydev]

You dont need access to the original repo. You can fork it and with the help of the fork you can make your PR. Here is how to do that Create PR from a fork

Thanks in advance and awaitig your PR.

[umer-mehmood]

Hello, I have forked and generated a PR regarding that $div helper. Kindly look into it and let me know if there are any changes. Regards, Umer Mehmood NorthBay Direct: +92 3234971359 umer.mahmood@northbaysolutions.net <faheem.khan@northbaysolutions.net> www.Northbaysolutions.com <http://www.northbaysolutions.com/>

…

On Fri, Nov 8, 2019 at 6:56 PM Planetary Development < ***@***.***> wrote: You dont need access to the original repo. You can fork it and with the help of the fork you can make your PR. Here is how to do that Create PR from a fork <https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork> Thanks in advance and awaitig your PR. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23?email_source=notifications&email_token=AMMDKPBMYBB4EGJAPKS7B4DQSVVXVA5CNFSM4JJT7T3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDSE5NA#issuecomment-551833268>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMMDKPGFTFAQMKQ7QVQBJU3QSVVXVANCNFSM4JJT7T3A> .

[planetarydev]

done with PR #24