Can the download driver baseUrl be customized?

Question

Can the download driver baseUrl be customized?

hongcha98 opened this issue 8 months ago · 5 comments

Hello, due to network problems, I may build a mirror of playwright.azureedge.net for access, but currently the baseUrl cannot be changed. Can it be changed to BaseUrl so that users can customize it? If so, I can provide one. PR?

const (
	playwrightCliVersion = "1.39.0"
	baseURL              = "https://playwright.azureedge.net/builds/driver"
)

Answer 1 · 2023-10-30T05:16:50.000Z

https://playwright.dev/docs/browsers#download-from-artifact-repository for browser, may be we can use env for download driver too From Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ 发件人: hongcha98 ***@***.***> 发送时间: Sunday, October 29, 2023 11:52:16 PM 收件人: playwright-community/playwright-go ***@***.***> 抄送: Subscribed ***@***.***> 主题: [playwright-community/playwright-go] Can the download driver baseUrl be customized? (Issue #383) Hello, due to network problems, I may build a mirror of playwright.azureedge.net for access, but currently the baseUrl cannot be changed. Can it be changed to BaseUrl so that users can customize it? If so, I can provide one. PR? const ( playwrightCliVersion = "1.39.0" baseURL = "https://playwright.azureedge.net/builds/driver" ) ― Reply to this email directly, view it on GitHub<#383>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ43DEOYJ34GVO7JIRH7AY3YBZ3TBAVCNFSM6AAAAAA6U5W2TCVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DOMBUGQ2DSMQ>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Answer 2 · 2023-10-30T08:26:10.000Z

As long as it can be customized, I really need this feature

Answer 3 · 2023-10-30T08:32:34.000Z

#384 waiting for review

Answer 4 · 2023-10-30T22:16:49.000Z

Maybe we can fall back to other CDNs like we do upstream? https://github.com/microsoft/playwright/blob/7bab19d807e1999e521b8e10fccfccf34cf2a741/packages/playwright-core/src/server/registry/index.ts#L39

Answer 5 · 2023-10-31T03:58:44.000Z

Maybe we can fall back to other CDNs like we do upstream? https://github.com/microsoft/playwright/blob/7bab19d807e1999e521b8e10fccfccf34cf2a741/packages/playwright-core/src/server/registry/index.ts#L39

I'll do it this week.