Inconsistent comment
akhmerov opened this issue · 2 comments
akhmerov commented
The comment here states that in case an event triggers a callback, the json will contain event: {'id': 'graph', 'event': 'click'}
. Despite that, a few lines below we see payload.event = event;
.
I am not sure which behavior is intended, however I would strongly prefer the one specified by the comment because I'd like to get the event emitter, and because the backend is free to disregard information it doesn't need.
akhmerov commented
NB: because the backend currently does not make use of the event
entry in the request body, this change does not break compatibility with dash
.
alexcjohnson commented
@akhmerov apologies that nobody ever addressed this issue. Events aren't even a thing anymore... closing.