pocketsvg/PocketSVG

Support for the "transform" attribute in common tags.

adario opened this issue · 5 comments

adario commented

Hello,

I'm attaching a patch against the current master (as of this writing) that adds support for the "transform" attribute in basic tags, e.g. rect, circle, ellipse and line. This has been tested on macOS 10.15.2 and iOS 13.3.

Should you decide to accept the patch, similar support would be useful for the path and polygon tags.

Thanks,
Dario

transform_attribute.diff.zip

arielelkin commented

Hi Dario!

Thank you very much for your patch. Could you please submit it as a pull request so that we can review it?

adario commented

Hi Ariel,

I'd love to, but I don't have write access to the repo, so I can't push my feature/transform_attribute branch — where else could I submit the PR from?

Thanks,
D.

arielelkin commented

You don't actually need to have write access to the repo in order to submit a PR, all you need to do is

  1. fork the pocketsvg repo (click on the Fork button in the top right)
  2. clone your fork locally
  3. apply your patch to your local fork
  4. commit and push
  5. open a pull request from your fork into the pocketsvg repo.

See: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

let me know if you get stuck 🙂

arielelkin commented

closed via #176

adario commented

I've created #176