- I do not write perfect code. Nobody does. This is rather obvious...
- I always want to improve myself. Everybody should. Nothing to explain here. Keep reading!
- I believe that Code Review is a useful tool to write quality code. It's a belief - Can't argue with that!
- I ask for Code Review to better myself as well as to improve the quality of the work I do.
- An issue is something that A) goes against the conventions, B) breaks the code, C) is simply missing or D) is dead wrong!
- A suggestion is something that is not an issue but could improve the code in some ways.
- I do not take comments personally. Not even a bit. Ever. It's work and I'm a professional!
- I do not write pejorative comments. Ever. Again, I'm a professional!
- I try to be constructive with my comments. The only way to go.
- I comment on each and every occurrence of an issue. This makes it easier for the developer to know all the lines that are needed to be edited.
- If I don't understand something, I ask about it. No shame in that!
- I always add a summary of the verbal discussions. It is a quick and efficient way to overcome issues, but others might have the same issue.
- I always reply to each and every comment, in a meaningful way. You never know who reads a thread and when, and who might learn from it now or then.
- When in doubt, write something fun! Having fun is a good way to avoid frustration...
This document is the result of the collaborative efforts of Miklós Antal (mkls), Adrián Sallai, Péter Seprűs (ppseprus) Kristóf Tombácz, Ábel Varga (rangeoshun) and Csaba Vályi (csabbee). Alphabetically.