unable to install due to fontawesome dependency errors

[ybootin]

Hi

First, thanks for providing this extension.

i've tryed to build and install the extension following the readme, but i faced an issue with fontawesome

ERROR in ./node_modules/@fortawesome/react-fontawesome/index.es.js 1:0-64
Module not found: Error: Can't resolve '@fortawesome/fontawesome-svg-core' in '/Users/yohan/Projects/sandbox/professor-prebid/node_modules/@fortawesome/react-fontawesome'
resolve '@fortawesome/fontawesome-svg-core' in '/Users/yohan/Projects/sandbox/professor-prebid/node_modules/@fortawesome/react-fontawesome'

I've tryed manual install of fontawesome-svg-core , by doing this

npm i --save @fortawesome/fontawesome-svg-core

but it come with others errors now.

i'm using node v14.17.4

try a build on a fresh install to reproduce (clone, npm install, npm start)

Thanks

[florianerl]

Hi,

thanks for your feedback!
Did you run npm install before trying to build it? Fontawesome is listed as dependency in package.json.
In case you just want to download the extension, it's also available in chrome's web-store: https://chrome.google.com/webstore/detail/professor-prebid-v02/kdnllijdimhbledmfdbljampcdphcbdc

[ybootin]

Hi @florianerl , thanks for your answer

yes i've followed the readme :

git clone git@github.com:prebid/professor-prebid.git
cd professor-prebid
npm install
npm start

I'm on Mac OSX 10.15.7

you can try out using a fresh docker install to solve the dependency issue

[florianerl]

HI @ybootin ,

you're right, it doesn't build with node 13. I updated the readme to node 15.12 as minimum requirement.

Tested in a fresh docker container:

Cloning into 'professor-prebid'...
remote: Enumerating objects: 4392, done.
remote: Counting objects: 100% (61/61), done.
remote: Compressing objects: 100% (49/49), done.
remote: Total 4392 (delta 18), reused 25 (delta 12), pack-reused 4331
Receiving objects: 100% (4392/4392), 6.26 MiB | 0 bytes/s, done.
Resolving deltas: 100% (3111/3111), done.
# cd professor-prebid
# npm i 

added 889 packages, and audited 890 packages in 24s

127 packages are looking for funding
  run `npm fund` for details

9 vulnerabilities (1 moderate, 7 high, 1 critical)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
npm notice 
npm notice New major version of npm available! 7.6.3 -> 8.10.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.10.0
npm notice Run npm install -g npm@8.10.0 to update!
npm notice 
# npm run start

> professor-prebid@0.0.1 start
> node utils/webserver.js

<i> [webpack-dev-server] Project is running at:
<i> [webpack-dev-server] Loopback: http://localhost:3000/, http://127.0.0.1:3000/
<i> [webpack-dev-server] Content not from webpack is served from '/professor-prebid/build' directory
assets by path *.js 32.4 MiB 11 assets
assets by path *.html 1.51 KiB
  asset popup.html 438 bytes [emitted]
  asset newtab.html 271 bytes [emitted]
  asset panel.html 225 bytes [emitted]
  asset options.html 220 bytes [emitted]
  asset app.html 215 bytes [emitted]
  asset devtools.html 175 bytes [emitted]
assets by path *.png 7.89 KiB
  asset icon-128.png 4.64 KiB [emitted] [from: src/assets/img/icon-128.png] [copied]
  asset icon-34.png 3.24 KiB [emitted] [from: src/assets/img/icon-34.png] [copied]
asset logo.svg 2.61 KiB [emitted] [from: src/assets/img/logo.svg] (auxiliary name: newtab)
asset manifest.json 684 bytes [emitted] [from: src/manifest.json] [copied]
asset index.scss 186 bytes [emitted] [from: src/pages/Popup/index.scss] [copied]
orphan modules 768 KiB [orphan] 412 modules
runtime modules 286 KiB 125 modules
modules by path ./node_modules/ 3.13 MiB 578 modules
modules by path ./src/ 257 KiB
  modules by path ./src/pages/ 216 KiB 39 modules
  modules by path ./src/inject/ 35.4 KiB
    modules by path ./src/inject/scripts/*.ts 26 KiB 4 modules
    modules by path ./src/inject/app/*.tsx 7.78 KiB 3 modules
    ./src/inject/inject.ts 606 bytes [built] [code generated]
    ./src/inject/injected.tsx 1.03 KiB [built] [code generated]
  modules by path ./src/*.ts 3.16 KiB
    ./src/logger.ts 1.83 KiB [built] [code generated]
    ./src/utils.ts 1.33 KiB [built] [code generated]
  ./src/constants.json 1.63 KiB [built] [code generated]
  ./src/assets/img/logo.svg 52 bytes [built] [code generated]
webpack 5.60.0 compiled successfully in 10496 ms

[florianerl]

Hi @ybootin ,

i removed the fontawesome dependency. It was just for only 1 Google Logo anyways.