prebid/professor-prebid

issue installing on mac os 11.6 with node v18.1.0

mkendall07 opened this issue · 2 comments

Thanks for publishing the extension!

I ran into an issue following the readme on npm install with the following environment

matt@Matts-Mac-mini ~ % node --version
v18.1.0
matt@Matts-Mac-mini ~ % npm --version
8.8.0

Error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @hot-loader/react-dom@17.0.1+4.13.0
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!   peer react@">=16.8.0" from @emotion/react@11.7.1
npm ERR!   node_modules/@emotion/react
npm ERR!     @emotion/react@"^11.7.1" from the root project
npm ERR!     peer @emotion/react@"^11.0.0-rc.0" from @emotion/styled@11.6.0
npm ERR!     node_modules/@emotion/styled
npm ERR!       @emotion/styled@"^11.6.0" from the root project
npm ERR!       3 more (@mui/material, @mui/styled-engine, @mui/system)
npm ERR!     3 more (@mui/material, @mui/styled-engine, @mui/system)
npm ERR!   23 more (@emotion/styled, @fortawesome/react-fontawesome, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"17.0.1" from @hot-loader/react-dom@17.0.1+4.13.0
npm ERR! node_modules/@hot-loader/react-dom
npm ERR!   @hot-loader/react-dom@"^17.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: react@17.0.1
npm ERR! node_modules/react
npm ERR!   peer react@"17.0.1" from @hot-loader/react-dom@17.0.1+4.13.0
npm ERR!   node_modules/@hot-loader/react-dom
npm ERR!     @hot-loader/react-dom@"^17.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/matt/.npm/eresolve-report.txt for a full report.

Note: when I installed node v15.12.0 (npm v7.6.3) - npm install succeeded.

Hi @mkendall07 ,

thanks for reporting this. Correct me if I'm wrong please but to me it looks like react doesn't support node 18 yet.

Hi @mkendall07 ,

thanks for reporting this. Correct me if I'm wrong please but to me it looks like react doesn't support node 18 yet.

Ah yep that would be the reason. I just did nvm install node to get the latest and got 18 so assumed that would be supported. Anyways, I'll close this since it's not an issue for this project. Thanks!