[Bug] IssueOpenedIcon returns an incorrect icon
emilyyang-ms opened this issue · 7 comments
emilyyang-ms commented
Describe the bug
IssueOpenedIcon returns an incorrect icon in React project.
Steps to reproduce
Steps to reproduce the behavior:
- in my react project, I import the icon:
import {IssueOpenedIcon} from '@primer/octicons-react'
- render the icon
- I see an incorrect icon rendered - a circle with ! in it.
Expected behavior
IssueOpenedIcon should return correct icon. (a circle with dot in it)
Screenshots
colebemis commented
👋 What version of @primer/octicons-react
are you using?
emilyyang-ms commented
Hi Cole,
Thanks for checking, I installed this version
***@***.***/components": "^28.5.0",
Please let me know if anything is wrong with this version.
Thanks,
Emily
From: Cole Bemis ***@***.***>
Sent: Tuesday, December 14, 2021 12:04 PM
To: primer/octicons ***@***.***>
Cc: Emily Yang ***@***.***>; Author ***@***.***>
Subject: Re: [primer/octicons] [Bug] IssueOpenedIcon returns an incorrect icon (Issue #707)
👋 What version of @primer/octicons-react are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprimer%2Focticons%2Fissues%2F707%23issuecomment-993935960&data=04%7C01%7Cemilyyang%40microsoft.com%7C01e16da87de344327dd008d9bf3cddb4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751090421689813%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=istcWBFVF1OjubduyvB718%2Ff0W%2FB1yqSKw0SzQF3Nfg%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWLUGSW632NUPUIQBTQ3HILUQ6PK3ANCNFSM5KBY27MA&data=04%7C01%7Cemilyyang%40microsoft.com%7C01e16da87de344327dd008d9bf3cddb4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751090421689813%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=rW2c2boRDnMDw%2Fz1yqJspEd3wWvCN0R9iFkwOLz2Eww%3D&reserved=0>.
Triage notifications on the go with GitHub Mobile for iOS<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cemilyyang%40microsoft.com%7C01e16da87de344327dd008d9bf3cddb4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751090421689813%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ILYGCeRPJyOyy0vmLJE6Nh7X8oj%2FfthqxUHSeqB3fu0%3D&reserved=0> or Android<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cemilyyang%40microsoft.com%7C01e16da87de344327dd008d9bf3cddb4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751090421689813%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Mszv6CyZb4uKR5BSoiLBXhdXEXdlERUmpRJdt6f9Lww%3D&reserved=0>.
colebemis commented
The latest version of @primer/react
(previously @primer/component
) is 34.0.0
. Upgrading should fix your issue.
If you don't want to update to the latest version of @primer/react
yet. Try installing the latest version of octicons explicitly:
npm install @primer/octicons-react@latest
emilyyang-ms commented
Thanks for the reply! I tried to update to latest @primer/react but it creates a bunch bugs(will deal with it later). For now I'll just update the lastest octicons and it works!
Thanks,
Emily
From: Cole Bemis ***@***.***>
Sent: Tuesday, December 14, 2021 1:39 PM
To: primer/octicons ***@***.***>
Cc: Emily Yang ***@***.***>; Author ***@***.***>
Subject: Re: [primer/octicons] [Bug] IssueOpenedIcon returns an incorrect icon (Issue #707)
The latest version of @primer/react (previously @primer/component) is 34.0.0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprimer%2Freact%2Freleases&data=04%7C01%7Cemilyyang%40microsoft.com%7C1a5d0317348c463f40ce08d9bf4a20f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751147385558500%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=9fzXtFVUr1puGt5Vahe7pXgdHF0d7Lg7hbf6Qv7cD6U%3D&reserved=0>. Upgrading should fix your issue.
If you don't want to update to the latest version of @primer/react yet. Try install the latest version of octicons explicitly:
npm install @***@***.***
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprimer%2Focticons%2Fissues%2F707%23issuecomment-994047211&data=04%7C01%7Cemilyyang%40microsoft.com%7C1a5d0317348c463f40ce08d9bf4a20f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751147385558500%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=a94x%2Bcdrnqeq3t8VphDI9kFvdIVSpt0AB0nr9Ynh638%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWLUGSV6PEDNJWREF3K5R23UQ62O5ANCNFSM5KBY27MA&data=04%7C01%7Cemilyyang%40microsoft.com%7C1a5d0317348c463f40ce08d9bf4a20f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751147385558500%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2Fsg0ddOdFBASvb0AvVv%2Bv4TRcaNwQFW2w9TjR%2FKDB5c%3D&reserved=0>.
Triage notifications on the go with GitHub Mobile for iOS<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cemilyyang%40microsoft.com%7C1a5d0317348c463f40ce08d9bf4a20f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751147385558500%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=rUanvTS8Szp4lVhDBxmXqcmOBeB4Z75SjivYRilPwzc%3D&reserved=0> or Android<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cemilyyang%40microsoft.com%7C1a5d0317348c463f40ce08d9bf4a20f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751147385558500%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2B%2F0wlHhWQB9O3Ff842JOFc2jzQcNnrdxMaoIqAbXrAM%3D&reserved=0>.
emilyyang-ms commented
Hi Cole,
I remember you mentioned the latest version of @primer/react has been changed, and we are still using the old library @primer/components 28.5.0. When I tried to update to the latest version, I figured out that the theming reference file has changed a lot, and some of the colors we were using are NOT in the new theming file now (like in old library, we can reference color auto.gray.1, but not in new library). So my questions are,
1. Do you suggest to upgrade to latest version of the library?
2. If we upgrade to latest version, what do you suggest to do with this theming reference change?
FYI, this project will be handed over to @michael ***@***.***>
Thanks,
Emily
From: Cole Bemis ***@***.***>
Sent: Tuesday, December 14, 2021 1:39 PM
To: primer/octicons ***@***.***>
Cc: Emily Yang ***@***.***>; Author ***@***.***>
Subject: Re: [primer/octicons] [Bug] IssueOpenedIcon returns an incorrect icon (Issue #707)
The latest version of @primer/react (previously @primer/component) is 34.0.0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprimer%2Freact%2Freleases&data=04%7C01%7Cemilyyang%40microsoft.com%7C1a5d0317348c463f40ce08d9bf4a20f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751147385558500%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=9fzXtFVUr1puGt5Vahe7pXgdHF0d7Lg7hbf6Qv7cD6U%3D&reserved=0>. Upgrading should fix your issue.
If you don't want to update to the latest version of @primer/react yet. Try install the latest version of octicons explicitly:
npm install @***@***.***
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprimer%2Focticons%2Fissues%2F707%23issuecomment-994047211&data=04%7C01%7Cemilyyang%40microsoft.com%7C1a5d0317348c463f40ce08d9bf4a20f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751147385558500%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=a94x%2Bcdrnqeq3t8VphDI9kFvdIVSpt0AB0nr9Ynh638%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWLUGSV6PEDNJWREF3K5R23UQ62O5ANCNFSM5KBY27MA&data=04%7C01%7Cemilyyang%40microsoft.com%7C1a5d0317348c463f40ce08d9bf4a20f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751147385558500%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2Fsg0ddOdFBASvb0AvVv%2Bv4TRcaNwQFW2w9TjR%2FKDB5c%3D&reserved=0>.
Triage notifications on the go with GitHub Mobile for iOS<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cemilyyang%40microsoft.com%7C1a5d0317348c463f40ce08d9bf4a20f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751147385558500%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=rUanvTS8Szp4lVhDBxmXqcmOBeB4Z75SjivYRilPwzc%3D&reserved=0> or Android<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cemilyyang%40microsoft.com%7C1a5d0317348c463f40ce08d9bf4a20f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637751147385558500%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2B%2F0wlHhWQB9O3Ff842JOFc2jzQcNnrdxMaoIqAbXrAM%3D&reserved=0>.
edokoa commented
/
187880 commented