progrium/localtunnel

url displayed in client incorrect

Bouke opened this issue · 4 comments

The url is not displaying correctly when connected to a private server. It still shows as [name].v2.localtunnel.com instead of [name].[myserver].

$ localtunnel-beta -s [myserver]:8000 8000 -n [name]
  Thanks for trying localtunnel v2 beta!
  Source code: https://github.com/progrium/localtunnel
  Donate: http://j.mp/donate-localtunnel

  Port 8000 is now accessible from http://[name].v2.localtunnel.com ...

Yeah, this is still hardcoded. Probably need to add an argument to the server. It wouldn't be that hard, want to try for a pull request? :)

Yeah I could give it a try. I would suggest replacing the -d (domain part) altogether, and replace it by something like hostname suffix. This value is then to be used for determining tunnel names and displayed in the banner. How do you think about this?

I suppose you could just use hostname to determine which part of the
subdomain to use for the tunnel name. What would suffix be for?

On Thu, Jan 24, 2013 at 6:45 AM, Bouke Haarsma notifications@github.comwrote:

Yeah I could give it a try. I would suggest replacing the -d (domain part)altogether, and replace it by something like hostname
suffix. This value is then to be used for determining tunnel names and
displayed in the banner. How do you think about this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/75#issuecomment-12654058.

Jeff Lindsay
http://progrium.com

See also PR #82. I guess the 'suffix' parameter could default to the system's hostname when not provided.