pucelle/vscode-run-on-save

Support for Jupyter notebooks

Closed this issue · 3 comments

gertvanhoey commented

Thank you for this very useful extension.

Unfortunately, onWillSaveDocument and onDocumentSaved are not triggered when saving a Jupyter notebook.

Would it be possible to provide support for running commands when saving Jupyter notebooks, making use of the following events?

https://code.visualstudio.com/updates/v1_66#_notebook-document-change-events
https://code.visualstudio.com/updates/v1_77#_notebook-lifecycle-event-onwillsavenotebookdocument

gertvanhoey commented

By looking at the source code, I figured out that executing a command when saving a Jupyter notebook does work by specifying "commandBeforeSaving" instead of "command". Thanks again.

  • 👍1
mfolkestad commented

This workaround does do the job for me, BUT it would be great if it could be implemented so that the scrip runs after I save instead of before. Now I just have to "save twice" for my intended functionality to work.

pucelle commented

Codes committed and will be released in coming version v1.7.1.
Please check it, thanks.