Add ability to do voltage and power control from experiments

liionpack Version

0.3.2

Python Version

3.8

Describe the bug

Why this is not possible?
"Charge at 1C until 4.2V",
"Hold at 4.2V until C/20"

Steps to Reproduce

No response

Expected behaviour

No response

Relevant log output

No response

Additional context

No response

I think the upper and lower cutoff voltage is 4.2 volts. Try your experiment with 4.1 V or lower.

But 4.2V is working finely in pybamm Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Gavin Wiggins ***@***.***> Sent: Thursday, July 28, 2022 7:10:46 PM To: pybamm-team/liionpack ***@***.***> Cc: Sourabh Jadhav ***@***.***>; Author ***@***.***> Subject: Re: [pybamm-team/liionpack] Experiment[Bug]: (Issue #174) I think the upper and lower cutoff voltage is 4.2 volts. Try your experiment with 4.1 V or lower. — Reply to this email directly, view it on GitHub<#174 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AU7LVHRVDMW2SWWFL466YILVWKEV5ANCNFSM543634MQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

In liionpack voltage limits are checked as shown below. So if your experiment exceeds these voltage limits then it will exit the simulation or at least show a warning.

liionpack/liionpack/solvers.py

Lines 441 to 448 in 306ef75

    
           # 06 Check if voltage limits are reached and terminate 
        
           if np.any(temp_v < self.v_cut_lower): 
        
               lp.logger.warning("Low voltage limit reached") 
        
               vlims_ok = False 
        
           if np.any(temp_v > self.v_cut_higher): 
        
               lp.logger.warning("High voltage limit reached") 
        
               vlims_ok = False 
        
           # 07 Step the electrochemical system

In liionpack voltage limits are checked as shown below. So if your experiment exceeds these voltage limits then it will exit the simulation or at least show a warning.

liionpack/liionpack/solvers.py

Lines 441 to 448 in 306ef75

# 06 Check if voltage limits are reached and terminate

if np.any(temp_v < self.v_cut_lower):

lp.logger.warning("Low voltage limit reached")

vlims_ok = False

if np.any(temp_v > self.v_cut_higher):

lp.logger.warning("High voltage limit reached")

vlims_ok = False

# 07 Step the electrochemical system

I want to implement CCCV in liionpack. I already implemented successfully CCCV in pybamm

Apologies for not checking these issues regularly. I need to sort out my github notifications. As discussed on the PyBaMM discussion this functionality needs to be added. Liionpack only works for CC and drive cycles not voltage or power driven experiments. Just FYI this will probably be quite a significant development and is not a high priority for me right now

@Sourabh-Jadhav-2 GitHub supports syntax highlighted code blocks. See the links below for more information. There's no need to take screenshots of code or terminal output.

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#quoting-code

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks

Were you ever able to resolve the issue? I'm experiencing the same problem

	# 06 Check if voltage limits are reached and terminate
	if np.any(temp_v < self.v_cut_lower):
	lp.logger.warning("Low voltage limit reached")
	vlims_ok = False
	if np.any(temp_v > self.v_cut_higher):
	lp.logger.warning("High voltage limit reached")
	vlims_ok = False
	# 07 Step the electrochemical system