Breaking downstream change
devendragovil opened this issue · 3 comments
What
Recent change in TopoNetX module is leading to test failures in the TopoModelX suite. It has not been detected yet, because the breaking change was made after the last TopoModelX pytest suite was run via GH-Actions.
Why
The recent PR 1ff5a45 has this change in the down_laplacian_matrix method for simplicial complex.
Earlier, the weight parameter was being overwritten internally vs raising the issue now.
The test_forward test case fails in the following two files for TopoModelX
- test/nn/simplicial/test_scnn.py
- test/nn/simplicial/test_sccnn.py
This should be fixed in TopoModelX. The previous solution only hid a potential error. In the case of the mentioned tests, the use of weight = True is invalid.
Okay, I have made the necessary changes in a branch that I am working at, planning to raise a PR today, so that'll fix it.
Resolved using a changes made in TopoModelX.