Add Mypy typing
Closed this issue · 3 comments
brandonwillard commented
This project needs type annotations and a Mypy pre-commit
hook.
majidaldo commented
just throwing the idea here to just generate the types from running the tests.
(/mypy/ typing? or just typing?)
brandonwillard commented
just throwing the idea here to just generate the types from running the tests.
(/mypy/ typing? or just typing?)
This issue is for Mypy (i.e. checked typing), as well as the manual addition of type hints. This codebase is small enough for that to be done manually.
majidaldo commented
can be closed (initially) with 7f9accb#diff-789a9a451148e9f433bf6f9884fb3eb71cf80e3b44df048d464f081b53eb95a4
but the typing work could be more comprehensive.