[BUG] `Asserts` inside `with` are not really asserting anything in qililab tests.

Question

[BUG] `Asserts` inside `with` are not really asserting anything in qililab tests.

Closed this issue a year ago · 4 comments

GuillermoAbadLopez commented a year ago

Expected behavior

We should assert things during tests.

Actual behavior

Asserts inside with, never make a test fail!

Answer 1 · 2023-10-26T14:10:22.000Z

What acuatlly is happening :

The error makes you leave the with, so the assert is never actually run
(I just debugged this, and its true, you never arrive to the assert, since the erro makes you leave the with)

Answer 2 · 2023-10-26T14:52:12.000Z

To be more precise, this only happens when using with pytest.raises.

Answer 3 · 2023-10-26T14:52:50.000Z

If this is fixed, please close the issue.

Answer 4 · 2023-10-26T14:54:37.000Z

There was only one test doing this incorrectly in the end, and has been changed!
Clossing the Issue 👍