quandtm/Milestone

Closed issues don't get removed from UI

Closed this issue · 6 comments

If an issue is downloaded in the app, but later on it it gets closed, the app on refresh doesn't then remove it from open.

multi-line
comment
test

Interesting, multi-line stuff works in WP7 but not in the web UI.

At a guess, it's sending just \r instead of \n?

Huh? The filters should filter based on state, which gets updated when downloading issues.

Sent from my Windows Phone


From: Paul Jenkins
Sent: 29/12/2011 10:04 AM
To: Michael Quandt
Subject: [Milestone] Closed issues don't get removed from UI (#23)

If an issue is downloaded in the app, but later on it it gets closed, the app on refresh doesn't then remove it from open.


Reply to this email directly or view it on GitHub:
#23

From what I can see, it's not actually updating any issues on refresh, its just not re-adding them.

Not that it'd matter a great deal, the Issue object doesn't implement INotifyPropertyChanged, so the UI is never going to know of any changes to properties.

I'm not sure if that'd retrigger a collection based filter, as I think that looks for INotifyCollectionChanged. Not certain on that though.

Oh I update the repository, not the issue, that's right.

Sent from my Windows Phone


From: Paul Jenkins
Sent: 29/12/2011 10:27 AM
To: Michael Quandt
Subject: Re: [Milestone] Closed issues don't get removed from UI (#23)

Not that it'd matter a great deal, the Issue object doesn't implement INotifyPropertyChanged, so the UI is never going to know of any changes to properties.


Reply to this email directly or view it on GitHub:
#23 (comment)