Nightly build against langchain4j main doesn't actually use the main branch
Closed this issue · 9 comments
We need to override the langchain4j.version property to the correct SNAPSHOT (and preferably also build the embeddings project and do the same with langchain4j-embeddings.version). Otherwise we're running against the version that we currently declare in the pom, which is not very useful to do nightly. The nightly job currently passes even though it should have started failing weeks ago due to langchain4j/langchain4j#1226
Or maybe it would be better to turn things around and introduce a CI build in langchain4j that runs the quarkus-langchain4j build for every PR in langchain4j? I briefly asked @langchain4j and he seems fine with it. WDYT @geoand? It would force langchain4j to be a bit more conservative, hopefully ;) (or at least let us know right away when something breaks)
It would force langchain4j to be a bit more conservative, hopefully
That is actually the exact opposite of what I want 😎.
I want upstream to do whatever is best for the project and the community and for us to adapt as necessary
I see :) ok then, in that case I guess I'll just try to fix the nightly job
🙏
It would force langchain4j to be a bit more conservative
It would not harm to at least be aware if I accidentally break anything
Sure yeah, that makes sense
I've submitted #701 to fix the nightly job on our side.
@langchain4j We can still have the tests in the langchain4j project too (but it may be too heavyweight), or maybe we could somehow make the nightly job send you notifications, or something?!
@jmartisk if notifications can be done, then it would probably be the easiest way?
Would this work? https://github.com/marketplace/actions/send-workflow-notifications
@jmartisk seems like yes, let's try it?