0.3.3 doesn't work with with Om 0.8.0 and react 0.12.2

Question

0.3.3 doesn't work with with Om 0.8.0 and react 0.12.2

Closed this issue 10 years ago · 13 comments

Tested it, reverted back to 11.1. Om 0.8.0 downloads 0.12.2. My HTML references 0.11.1. Tried to use 0.12.2, but that didn't work. Not sure how long this bastardization combination will continue. I guess at some point I will have to stop upgrading Om or om-bootstrap.

Answer 1 · 2015-01-21T03:27:10.000Z

You can make it work but some changes are required. om-bootstrap explicitly depends on om-0.7.1, so add this to your project.clj:

[racehub/om-bootstrap "0.3.3" :exclusions [om]]
[org.om/om "0.8.0"]

Also, in react-0.12.2 isValidComponent has been renamed to isValidElement. If you're planning to use advanced optimizations then I suggest adding a local copy of om-bootstrap to checkouts/ and replacing the two occurrences of isValidComponent in modal.cljs and util.cljs.

Perhaps om-bootstrap could change the dependency to [om "0.7.3" :scope "provided"]?

Answer 2 · 2015-01-21T15:46:48.000Z

that's a good call. I didn't realize that David would change the org name in his dependency, which kills dependency resolution. I'll make that change today.

Answer 3 · 2015-01-21T20:14:43.000Z

Okay, I've just pushed 0.3.4-SNAPSHOT. Can you guys try and let me know if it works? Here's the change:

#44

Answer 4 · 2015-01-21T20:15:29.000Z

@mstang, I still haven't gotten around to fixing that issue with the latest Om. Here it is: #40 You might take a look at that if it's urgent.

Answer 5 · 2015-01-21T20:16:22.000Z

Now that Om 0.8.0 is out, once we fix that issue I'm down to start pushing toward 0.4.0 on develop. @lostman, I'd take a pull req fixing those two references and other changes if you want. Thanks!

Answer 6 · 2015-01-27T15:22:00.000Z

@mstang, @lostman, can you guys confirm that this works? Cutting a release now.

Answer 7 · 2015-01-27T15:32:24.000Z

Okay, releasing 0.3.4 now. Give that a try. Also, I'm finally getting around to upgrading this lib to 0.8.0 today! The clone-with-props bug should get fixed by tomorrow. Thanks for your patience, guys.

Answer 8 · 2015-01-29T07:38:15.000Z

Awesome that you are still on to it 👍 Thanks.

Answer 9 · 2015-01-29T13:11:40.000Z

Thanks, looking forward to upgrading everything ;-)!

On Thu, Jan 29, 2015 at 12:38 AM, lgrapenthin notifications@github.com
wrote:

Awesome that you are still on to it [image: 👍] Thanks.

—
Reply to this email directly or view it on GitHub
#42 (comment).

Answer 10 · 2015-02-05T20:28:21.000Z

Is it now working with om 8? Our production app quickly stops rendering and spams react errors in the console. I am asking because if it is supposed to work, we'd schedule debugging our code against it.

Answer 11 · 2015-02-05T20:30:12.000Z

@lgrapenthin, I wasn't able to get to it before a weekend trip - I'm REALLY hoping I can do this today and get the 0.8.0 bugs ironed out. Thanks for hanging with me, guys.

Answer 12 · 2015-02-08T05:58:28.000Z

Okay, fixed! 0.4.0-SNAPSHOT should be good to go with 0.8.x.

Answer 13 · 2015-02-08T14:12:33.000Z

Great! I am looking forward to testing it!

Thanks for all your hard work!

regards,

Mark

On Sat, Feb 7, 2015 at 10:58 PM, Sam Ritchie notifications@github.com
wrote:

Closed #42 #42.

—
Reply to this email directly or view it on GitHub
#42 (comment).