Relative redirect is not followed correctly

Question

Relative redirect is not followed correctly

ioquatix opened this issue 7 years ago · 5 comments

According to https://tools.ietf.org/html/rfc7231#section-7.1.2 a relative location can be returned in the location header.

However, if the request for, say /foo/bar returns Location: baz, rack-test follow_redirects! generates a request for /baz, not /foo/baz like it probably should (and as supported by the RFC.

ioquatix commented 6 years ago

Thanks :)

perlun commented 6 years ago

NP!

Answer 1 · 2018-04-06T18:33:04.000Z

However, if the request for, say /foo/bar returns Location: baz, rack-test follow_redirects! generates a request for /baz, not /foo/baz like it probably should (and as supported by the RFC.

Thanks for letting us know! Would you be willing to submit a PR that fixes this incorrect behavior?

Answer 2 · 2018-04-06T21:44:35.000Z

We can use Ruby’s stdlib URI parser

Answer 3 · 2018-04-06T23:07:53.000Z

Okay I've made a PR.