radiac/django-tagulous

tagulous.admin.enhance() will change the list_display to a list

jedie opened this issue · 2 comments

jedie commented

Think it's a bad idea to change the "list_display" of a ModelAdmin class to a list, because it's mutable and this may result in side effects.

radiac commented

That's a fair point. I'm not sure how much real world risk with it, but may as well address it in the next release. There's potential that someone could now expect it to be a list, but that'd be reasonably simple for them to change as long as it's listed in the upgrade notes.

Same for get_autocomplete_fields() ;)