rail-berkeley/softlearning

Results folder should be configurable through cli

hartikainen opened this issue · 0 comments

Right now we hard-code the local_dir and upload_dir, which is not ideal for everyone. Should be changed to some sane default and then allow configuration via cli.

The hard-coded part is currently here:

# TODO(hartikainen): Allow local dir to be modified through cli args
local_dir = '~/ray_results'
if command_line_args.mode == 'debug':
local_dir = os.path.join(local_dir, 'debug')
local_dir = os.path.join(
local_dir,
command_line_args.universe,
command_line_args.domain,
command_line_args.task)

What needs to be done is to add a local_dir cli arg and change the lines above to use that. One thing to note is that the local_dir and upload_dir might get a bit weird if they're set to different locations. Maybe this is okay and there shouldn't be any special handling for that or maybe we need to match them somehow.