rappasoft/laravel-boilerplate

Social Login Using Github

soringabriel opened this issue · 1 comments

On my project started from this repo I'm encountering the following issue: Socialite for github returns name as null, and in registerProvider (from UserService) it attempts to set this property as the newly created user's name.

However in the database, users name cannot be null which leads to github login to fail. A simple fix would be on line: https://github.com/rappasoft/laravel-boilerplate/blob/master/app/Domains/Auth/Services/UserService.php#L87 to use $info->name ?? $info->nickname (as the nickname is not null in my case at least)

However I don't know if I will have the time to send this PR so if anyone else can fix it, I think it will help the project :D

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.