rcnl-org/nmsm-core

[BUG] *NCP Activation Minimization Error Center Not Being Used*

Closed this issue · 1 comments

Describe the bug
When you define an error center for activation minimization in NCP, the error center value is not used in formulating the cost function.

To Reproduce
Steps to reproduce the behavior:
Run any NCP problem with an error center value define for activation minimization, and note that the selected value of the error center has no influence on the results.

Expected behavior
If an error center is specified for activation minimization in NCP, it should affect the solution.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Windows, Mac M1, Mac Intel]
  • OpenSim Version: [e.g. 4.4]
  • MATLAB Version: [e.g. 2022b]
  • NMSM Pipeline Version: [e.g. v1.0]

Additional context
Add any other context about the problem here.

Also, I just realized that in the NCP settings for activation_minimization,

activation_minimization
<is_enabled>true</is_enabled>
<max_allowable_error>0.5</max_allowable_error>

<max_allowable_error> does not have the effect that it should on reducing peak muscle activations that are above the <max_allowable_error> value. For example, for a max activation of 0.869 produced using <max_allowable_error> 1, reducing <max_allowable_error> to 0.5 causes the max activation to drop to only 0.860. The <max_allowable_error> setting for activation minimization should have a more pronounced effect on the predicted muscle activations.