decorators.py

Question

decorators.py

Closed this issue 7 years ago · 12 comments

powerhouseofthecell commented 7 years ago

I'm under the impression that I must be missing something important here, because I can't seem to find this issue elsewhere on the web. However, my pip-installed version of django_twilio has a decorators.py file which is inconsistent with the one here on GitHub. The main problem seems to arise from these two import statements:

from twilio.twiml import Verb
from twilio.util import RequestValidator

The above statements should be:

from twilio.twiml import TwiML as Verb
from twilio.request_validator import RequestValidator

The current GitHub version has this correction, but the pip-installed version does not.

Please do let me know if I am foolishly missing something, or if this is a known problem.

Best,
potc

Answer 1 · 2017-08-03T20:52:10.000Z

@rdegges probably needs to push a new version to pypi.

Answer 2 · 2017-08-05T03:52:16.000Z

Definitely need to get this out to pypi asap. I'm unable to use the default pip installations of twilio and django_twilio.

Awesome work though on this project guys! And thanks for posting @powerhouseofthecell

Answer 3 · 2017-08-15T18:59:57.000Z

Having the same issue! Is there an ETA on when this is going to get pushed? I also can't install through pip because of this!

Thanks for the post @powerhouseofthecell!

Answer 4 · 2017-08-15T19:10:06.000Z

Unfortunately I think the repo is entering an unmaintained state. @willex your best bet is to probably create your own fork and use that.

Answer 5 · 2017-08-23T19:19:04.000Z

+1 for pushing this amendment to pypi

Answer 6 · 2017-08-29T08:59:44.000Z

I've pushed a forked version of django-twilio to pypi as django-twilio2 which has the fix for this

Answer 7 · 2017-11-08T17:49:15.000Z

Hey @mulka -- I'm happy to add you as a owner of the repo here. Your work would be greatly appreciated!

Answer 8 · 2017-11-08T17:49:52.000Z

If you're amenable to that I'm happy to hand over commit and PyPI access. I've mentioned this before in different issues, but I no longer use Django in my day-to-day work, and haven't been keeping up with changes to these libraries.

Answer 9 · 2017-12-28T02:15:21.000Z

Hi all,

I'm a new contributor/maintainer of this project. Thanks @rdegges. I'll be looking through the issues and PRs as quickly as I can. Please provide any updates (usage, issues, workarounds) that you may have, or patches, as PRs; otherwise it's in order of importance, followed by morality.

Answer 10 · 2018-01-31T00:11:09.000Z

Just to update everyone here, 0.9.0a1 is available on PyPI. It has all of the support for twilio 6.x and support for django 2.0 as is based on the MRs and issues here so far.

My company is testing today and deploying tonight with the alpha build from PyPI. If all goes well in the coming days up through the sprint (maybe earlier), I'll release either a rc build or just the proper 0.9.0 build to PyPI.

Please let me know if you need anything.

Answer 11 · 2018-01-31T00:11:56.000Z

I'm closing this issue for now. If you still have issues or any comments related to this issue, please re-open as needed.

Answer 12 · 2018-02-07T18:32:14.000Z

Hey guys, I have released version 0.9.0, so if you're still receiving notifications for github, hopefully this reaches you!