Gerard from Lyon reported an error with his Wiki
Closed this issue · 6 comments
voz commented
It shows an error when loading (see the screenshot below). @ajwild could it be related to some of the recent changes?
ajwild commented
For reference, there are 13 of these apps in normal spaces and 217 within ILS. The app has been updated to require a vault which is why this error is displayed.
@voz suggested to detect the environment and use the vault within an ILS, and app-data when in a normal space.
dgillet commented
In the spirit of graceful degradation of app, they should either create the vault if missing (if possible) or display a message (proposing to create one)
Denis
… On 8 Feb 2017, at 17:51, Alex Wild ***@***.*** ***@***.***>> wrote:
For reference, there are 13 of these apps in normal spaces and 217 within ILS. The app has been updated to require a vault which is why this error is displayed.
@voz <https://github.com/voz> suggested to detect the environment and use the vault within an ILS, and app-data when in a normal space.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#390 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACr9cSfIq1QjaKBYnMo6GCX2m0D8fTI-ks5rafJ9gaJpZM4L7Cbu>.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/react-epfl/gadget","title":"react-epfl/gadget","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png <https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png>","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png <https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png>","action":{"name":"Open in GitHub","url":"https://github.com/react-epfl/gadget ***@***.*** in #390: For reference, there are 13 of these apps in normal spaces and 217 within ILS. The app has been updated to require a vault which is why this error is ***@***.*** suggested to detect the environment and use the vault within an ILS, and app-data when in a normal space."}],"action":{"name":"View Issue","url":"#390 (comment) <#390 (comment)>"}}}
voz commented
@dgillet we were thinking to make the app work with AppData (like it used to) when it is outside of an ILS (case of Gerard). And when the app is inside of an ILS we can make the app create Vault if it does not exist.
Not sure about requiring to create a Vault subspace when placed into a regular space, this can introduce confusion for people not familiar with ILSs.
dgillet commented
OK, it also makes sense (but will be only open social compatible)
On 9 Feb 2017, at 09:27, Andrii Vozniuk <notifications@github.com<mailto:notifications@github.com>> wrote:
@dgillet<https://github.com/dgillet> we were thinking to make the app work with AppData (like it used to) when it is outside of an ILS (case of Gerard). And when the app is inside of an ILS we can make the app create Vault if it does not exist.
Not sure about requiring to create a Vault subspace when placed into a regular space, this can introduce confusion for people not familiar with ILSs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#390 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACr9cY_QUuDc7Z8qa_gnKtUpQVH3vAHHks5ras3cgaJpZM4L7Cbu>.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/react-epfl/gadget","title":"react-epfl/gadget","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/react-epfl/gadget"}},"updates":{"snippets":[{"icon":"PERSON","message":"@voz in #390: @dgillet we were thinking to make the app work with AppData (like it used to) when it is outside of an ILS (case of Gerard). And when the app is inside of an ILS we can make the app create Vault if it does not exist.\r\n\r\nNot sure about requiring to create a Vault subspace when placed into a regular space, this can introduce confusion for people not familiar with ILSs."}],"action":{"name":"View Issue","url":"#390 (comment)"}}}