Class constants `Criteria::ASC|DESC` are deprecated in favor of `Doctrine\Common\Collection\Order`
Closed this issue · 1 comments
julienfastre commented
According to the UPGRADE guide, classes constants related to Criteria::ASC
and Criteria::DESC
are deprecated, in favor of Doctrine\Common\Collection\Order
.
We can also use the rule Rector\Renaming\Rector\ClassConstFetch\RenameClassConstFetchRector
for this (like in #294).
Can I also write a PR for this ?
This is in the package doctrine-collection: I think I will need to create a new ruleset and test suite, isn't it ?
samsonasik commented
yes please 👍