RemoveRedundantDefaultPropertyAnnotationValuesRector with JoinColumn

[eerison]

This rule is removing JoinColumn annotation

-     * @ORM\JoinTable(name="vouchers_subscriptions",
-     *     joinColumns={@ORM\JoinColumn(name="voucher_id", referencedColumnName="id")},
-     *     inverseJoinColumns={@ORM\JoinColumn(name="subscription_id", referencedColumnName="id")}
-     *     )
+     * @ORM\JoinTable(name="vouchers_subscriptions", joinColumns={(name="voucher_id")}, inverseJoinColumns={(name="subscription_id", referencedColumnName="id")})

But in the doc it needs of JoinColumn

https://www.doctrine-project.org/projects/doctrine-orm/en/2.9/reference/association-mapping.html#many-to-many-unidirectional

[TomasVotruba]

Thanks for reporting. That should not happen.

Please send failing test fixture to the responsible rule, so we have failing CI in here.

[eerison]

Thanks for reporting. That should not happen.

Please send failing test fixture to the responsible rule, so we have failing CI in here.

Hi @TomasVotruba do you have any example how can I send it?

failing test fixture to the responsible rule

[TomasVotruba]

First step would be to reproduce the bug in http://getrector.org/demo

Then you can follow this docs: https://github.com/rectorphp/rector/blob/main/docs/how_to_add_test_for_rector_rule.md

The goal is to add fixture file to /Fixture directory of responsible rule.

[TomasVotruba]

We're narrowing issues to keep focus on active and engaging contributor to keep project growing.
Closing for lack of activity last 7 months :) Thank you for understanding.

Feel free to re-open with the PR with a fix 👍