URI.unescape is obsolete
RandieM opened this issue · 6 comments
RandieM commented
Hey there,
I am hoping to upgrade my RefineryCMS app to Ruby 2.7.3, but I get this warning message:
.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/bundler/gems/refinerycms-1b73e0b5e1ce/pages/app/presenters/refinery/pages/menu_presenter.rb:92: warning: URI.unescape is obsolete
Would it be possible to change this obsolete method to something else, e.g. CGI.unescape ? I am happy to submit a PR, if this helps.
Thanks.
anitagraham commented
Good idea.
RandieM commented
Hi @anitagraham,
Thanks for your answer.
What exactly does "good idea" refer to? Changing the obsolete method or submitting the PR? Or may be both?
anitagraham commented
Both!
…--
Anita Graham
***@***.***
0411 645 149
From: RandieM ***@***.***>
Reply to: refinery/refinerycms ***@***.***>
Date: Tuesday, 29 June 2021 at 11:40 pm
To: refinery/refinerycms ***@***.***>
Cc: Anita Graham ***@***.***>, Mention ***@***.***>
Subject: Re: [refinery/refinerycms] URI.unescape is obsolete (#3500)
Hi @anitagraham,
Thanks for your answer.
What exactly does "good idea" refer to? Changing the obsolete method or submitting the PR? Or may be both?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.