renovatebot/helm-charts

Versions for kindest/node are not updated

Closed this issue · 4 comments

Hi,

I take my inpsiration from the renovate configuration of this repo for my own charts and found a bug when dealing with kindest/node image.

The regex in renovate.json should not have an additionnal space just after the comment character.

Another problem is that only patch updates should be applied as you want to launch different versions on Kubernetes and not the latest one.

Can I commit a PR?

Sure

The regex is right, the workflow config is wrong. There should always be a space like # renovate:

@viceice It seems there are some inconsistencies in default renovate preset here : https://github.com/renovatebot/.github/blob/main/default.json

Is the regexManager "Update version: variables in workflows" at the end of the file also wrong?

Yes, as you can see, the other always have the space.