Module import breaks projects with Objective-C++ Code

[melbic]

V 1.30 breaks projects which use Objective-C++ code, because modules aren't supported there.
Is there any chance to change the code to something like this?

#if __has_feature(modules)
    @import CoreData;
#else
    #import <CoreData/CoreData.h>
#endif

(Copied the idea from here (stripe/stripe-ios#220 (comment))

I could do a pull request if you're willing to merge it.

[justin]

Yep. we'd for sure take that. Thanks for doing it!

• j

Sent from my iPod shuffle

On Apr 4, 2016, 01:09 -0600, Samuel Bichselnotifications@github.com, wrote:

V 1.30 breaks projects which use Objective-C++ code, because modules aren't supported there.
Is there any chance to change the code to something like this?

#if__has_feature(modules) @import CoreData; #else#import<CoreData/CoreData.h>#endif

(Copied the idea from here (stripe/stripe-ios#220 (comment)(stripe/stripe-ios#220 (comment)))

I could do a pull request if you're willing to merge it.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly orview it on GitHub(#325)

[rentzsch]

@melbic I'm going to do a bug fix release of mogenerator for this.

Will you be able to issue the Pull Request in the next day or two or want to catch the next train?

[melbic]

I'll try to do it today. If you don't get PR by tonight I'll catch the next one.

[melbic]

I tested it with my project which didn't compile with the new version and this does the trick.

[rentzsch]

@melbic thanks for 1) filing the issue 2) fixing it 3) turning it around quickly. So like triple-thanks!