rharter/auto-value-moshi

Support of default values using builders

david-gang opened this issue · 7 comments

david-gang commented

This issue is maybe covered in #20 but is closed.
From AutoValue 1.7 the builder api is available, which makes it possible to set default values using builders.
This is already implemented in autovalue-gson from this commit: rharter/auto-value-gson@a1aa36e.
Can this also be implemented in autovalue-moshi?

david-gang commented

Hi @rharter , Are prs welcome ? I could give it try as the gson solution is very close to what we will need here but i want to be sure that this pr will get be reviewed by someone.

Thanks

ZacSweers commented
david-gang commented

This could be closed because it was already implemented by 54b1952

Could a new version please released?

ZacSweers commented

It's a holiday week here in the states and this project is maintained in our free time. Please be patient

david-gang commented

It's a holiday week here in the states and this project is maintained in our free time. Please be patient

Will wait. Wanted to remind that i have also some merits in the production of the last version :-)
I am not nudging without doing anything to improve the situation.

david-gang commented

@ZacSweers kindly reminder. i invested quite reasonable time in the PRs and i want to get it into a release. is there a timeline when you plan the next release?

rharter commented

Sorry about that, @david-gang, I'll take a look this week at what we can do to get something out.