Bug: undo after ClangFormat does undo twice, erasing previous changes

Question

Bug: undo after ClangFormat does undo twice, erasing previous changes

aravind2612krishna opened this issue 5 years ago · 9 comments

aravind2612krishna commented 5 years ago

Neovim, windows.
To reproduce :
In the simple file below, try changing Hello to something else, then selecting the lines and doing a clang format.
Then, doing an Undo undoes the Hello change as well.

Answer 1 · 2020-04-16T21:07:04.000Z

I think I have a local fix for this, can prepare a PR tomorrow. Would it be possible for you to try it out?

Answer 2 · 2020-04-17T06:02:03.000Z

Least I can do. Thanks

Answer 3 · 2020-04-17T22:57:00.000Z

Met some unexpected issues when I added a small unit test for the issue at hand. Still works in my normal environment though. Will continue tomorrow.

…

On Fri, 17 Apr 2020, 08:02 aravind2612krishna, ***@***.***> wrote: Least I can do. Thanks — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#98 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJB5UQRC7HZAJRU26B2CBXLRM7WGVANCNFSM4MHPPDDA> .

Answer 4 · 2020-04-18T17:39:53.000Z

@aravind2612krishna, while I still have issues in the test, it works for my normal vim/nvim instance. At your convenience, it would be valuable it you could try it out and see if the fix is also valid in your setup.

Answer 5 · 2020-04-20T08:58:16.000Z

I tried with the plugin from 'Kypert/vim-clang-format', but similar behavior persists.

Answer 6 · 2020-04-20T12:08:21.000Z

Interesting, just to make sure, did you use the fix branch:

Plug 'Kypert/vim-clang-format', { 'branch' : 'fix/issues/98' }

Answer 7 · 2020-04-20T13:56:30.000Z

Apologies. It does work in that branch, I just tried.

Answer 8 · 2020-07-03T22:51:24.000Z

Do you know why the undojoin is there?

Answer 9 · 2022-10-25T19:36:45.000Z

Can this PR be accepted? I have this same issue with undos