is riscv-arch-test encoding.h out of date?
dansmathers opened this issue · 5 comments
see pull #350
I'm trying to add the CLIC CSRs to encoding.h but it looks like the riscv-arch-test encoding.h might just be out-of-date and should be updated with encoding.h at: https://github.com/riscv-software-src/riscv-isa-sim/blob/master/riscv/encoding.h ?
that encoding.h already has the clic CSRs included.
This is a known problem. This should be updated on a more regular basis (automatically)
All encoding.h variants are created using the riscv-opcodes repo. As discussed in the ACT-SiG. The encoding.h checked into riscv-arch-test repo should undergo a change only if a test requires that change. Spuriously updating the encoding.h alone will cause a lot of unwanted churn with no real benefits.
If you are writing tests for CLIC, then the PR contributing those tests should include an update of the encoding.h as well since those tests require those.
Are you sure you don't want to just update it to a newer version from the repo? It seems pretty out of date. I think I dont see any of the new CSRs defined in priv 1.12: mconfigptr, mseccfg, mseccfgh, menvcfg, henvcfg, senvcfg, menvcfgh, henvcfgh. So the current state of encoding.h is something between 1.11 and 1.12?
@dansmathers yes you are right.. the encoding.h in this repo is pretty old - but its exactly what the current test-suites require. Enabling isolated updates of the encoding.h will lead to a lot of unnecessary updates in this repo without actual usage/contribution within the test-suites themselves. Hence the decision to avoid this at the moment.