Missing dependencies in package.json

Question

Missing dependencies in package.json

Closed this issue 5 years ago · 2 comments

Im using JSPM to package your module but it has problems doing so because package.json does not declare 'prop-types' or 'object-assign' as either dependencies or peerDependencies. This results in a runtime error loading your module because JSPM cant include undeclared dependencies without some extra JSPM override config.

Would you consider accepting a P.R to correct this?

Answer 1 · 2019-02-19T15:44:29.000Z

Absolutely, please go ahead and I’ll have it merged ASAP tir. 19. feb. 2019 kl. 05:05 skrev Colm <notifications@github.com>:

Im using JSPM to package your module but it has problems doing so because package.json does not declare 'prop-types' or 'object-assign' as either dependencies or peerDependencies. This results in a runtime error loading your module because JSPM cant include undeclared dependencies without some extra JSPM override config. Would you consider accepting a P.R to correct this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#44>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABfQp_Kdv_9-GwwCaQp78-l5fnoUmSaZks5vO3fsgaJpZM4bCIOn> .

-- Mvh, Sven Anders Robbestad https://www.robbestad.com <http://www.robbestad.com/>

Answer 2 · 2019-02-20T20:03:58.000Z

Thanks for the quick turn around. Closing as this is resolved via e04af2d