0.1.0 fails to compile
Closed this issue · 4 comments
haarp commented
Hello,
I'm currently making a Gentoo ebuild for this tool. 0.0.6 compiles successfully, but 0.1.0 fails with:
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp: In member function ‘DDCA_MCCS_Version_Spec FeatureValue::vspec() const’:
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp:74:19: error: ‘struct DDCA_Feature_Metadata’ has no member named ‘vcp_version’
74 | return _finfo->vcp_version;
| ^~~~~~~~~~~
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp: In member function ‘void FeatureValue::dbgrpt() const’:
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp:133:5: error: ‘ddca_dbgrpt_feature_metadata’ was not declared in this scope; did you mean ‘ddca_free_feature_metadata’?
133 | ddca_dbgrpt_feature_metadata(_finfo, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ddca_free_feature_metadata
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/vcpthread.cpp: In member function ‘void VcpThread::getvcp(uint8_t, bool)’:
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/vcpthread.cpp:335:15: error: ‘ddca_dbgrpt_feature_metadata’ was not declared in this scope; did you mean ‘ddca_free_feature_metadata’?
335 | ddca_dbgrpt_feature_metadata(finfo, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ddca_free_feature_metadata
Cheers!
rockowitz commented
Looks like you're using an old version of libddcutil. Field vcp_version
was added to struct DDCA_Feature_Metadata in release 0.9.8. See Shared
Library Changes for Release 0.9.8 <http://www.ddcutil.com/c_api_98/>.
The shared library is, as of release 0.9.6, under SONAME control, so
these kinds of mismatches should be easier to spot going forward.
…On 1/15/20 4:56 AM, haarp wrote:
Hello,
I'm currently making a Gentoo ebuild for this tool. 0.0.6 compiles
successfully, but 0.1.0 fails with:
|/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp:
In member function ‘DDCA_MCCS_Version_Spec FeatureValue::vspec()
const’:
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp:74:19:
error: ‘struct DDCA_Feature_Metadata’ has no member named
‘vcp_version’ 74 | return _finfo->vcp_version; | ^~~~~~~~~~~
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp:
In member function ‘void FeatureValue::dbgrpt() const’:
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp:133:5:
error: ‘ddca_dbgrpt_feature_metadata’ was not declared in this scope;
did you mean ‘ddca_free_feature_metadata’? 133 |
ddca_dbgrpt_feature_metadata(_finfo, 1); |
^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ddca_free_feature_metadata
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/vcpthread.cpp:
In member function ‘void VcpThread::getvcp(uint8_t, bool)’:
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/vcpthread.cpp:335:15:
error: ‘ddca_dbgrpt_feature_metadata’ was not declared in this scope;
did you mean ‘ddca_free_feature_metadata’? 335 |
ddca_dbgrpt_feature_metadata(finfo, 1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ddca_free_feature_metadata |
Cheers!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#17?email_source=notifications&email_token=ADMGY3SNVQ7AKDXY6UWKA5DQ53MTVA5CNFSM4KHAWXL2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IGJR5WA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMGY3VOGFQVRZ2NPDTUPXDQ53MTVANCNFSM4KHAWXLQ>.
haarp commented
Thanks. Indeed, it builds fine with ddcutil-0.9.8. I was using an older version of ddcutil before, due to rockowitz/ddcutil#101. You should edit BUILDING.md to mention 0.9.8 instead of 0.9.6 tho.
rockowitz commented
On 1/15/20 9:18 AM, haarp wrote:
Thanks. Indeed, it builds fine with ddcutil-0.9.8. I was using an
older version of ddcutil before, due to rockowitz/ddcutil#101
<rockowitz/ddcutil#101>.
Unclear to me how issue #101 implies that an older version of ddcutil
should be used. The thread concludes with changes pushed to branch
0.9.9-dev.
You should edit BUILDING.md to mention 0.9.8 instead of 0.9.6 tho.
Fixed in my local version. It will be a while before this change, along
with many others, is pushed to branch 0.1.1-dev. Keeping so many pieces
of documentation in sync is a challenge. I'm considering just putting a
pointer to the online documentation in file BUILDING.md.
… —
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#17?email_source=notifications&email_token=ADMGY3XD4Q3MZX2JJQL4CA3Q54LLBA5CNFSM4KHAWXL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJAORMQ#issuecomment-574679218>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMGY3SOLHOD2KQZYR4WT43Q54LLBANCNFSM4KHAWXLQ>.
haarp commented
Unclear to me how issue #101 implies that an older version of ddcutil should be used.
It doesn't. I fell back to 0.9.7 when 0.9.8 wouldn't build. Only later did I find out about 101.
Anyway, with this solved, I'll close this. Thanks a lot!