rockowitz/ddcui

0.1.0 fails to compile

Closed this issue · 4 comments

haarp commented

Hello,

I'm currently making a Gentoo ebuild for this tool. 0.0.6 compiles successfully, but 0.1.0 fails with:

/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp: In member function ‘DDCA_MCCS_Version_Spec FeatureValue::vspec() const’:
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp:74:19: error: ‘struct DDCA_Feature_Metadata’ has no member named ‘vcp_version’
   74 |    return _finfo->vcp_version;
      |                   ^~~~~~~~~~~
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp: In member function ‘void FeatureValue::dbgrpt() const’:
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/feature_value.cpp:133:5: error: ‘ddca_dbgrpt_feature_metadata’ was not declared in this scope; did you mean ‘ddca_free_feature_metadata’?
  133 |     ddca_dbgrpt_feature_metadata(_finfo, 1);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |     ddca_free_feature_metadata

/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/vcpthread.cpp: In member function ‘void VcpThread::getvcp(uint8_t, bool)’:
/var/tmp/portage/app-misc/ddcui-0.1.0/work/ddcui-0.1.0/src/nongui/vcpthread.cpp:335:15: error: ‘ddca_dbgrpt_feature_metadata’ was not declared in this scope; did you mean ‘ddca_free_feature_metadata’?
  335 |               ddca_dbgrpt_feature_metadata(finfo, 1);
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |               ddca_free_feature_metadata

Cheers!

haarp commented

Thanks. Indeed, it builds fine with ddcutil-0.9.8. I was using an older version of ddcutil before, due to rockowitz/ddcutil#101. You should edit BUILDING.md to mention 0.9.8 instead of 0.9.6 tho.

haarp commented

Unclear to me how issue #101 implies that an older version of ddcutil should be used.

It doesn't. I fell back to 0.9.7 when 0.9.8 wouldn't build. Only later did I find out about 101.

Anyway, with this solved, I'll close this. Thanks a lot!