Code questions
lkrocek opened this issue · 0 comments
lkrocek commented
- Not clear to me why is this Client library sending pings on server. This should be part of server or if this lib is able to being as a server as well it should be switch automatically or by configuration, so for me it's doing an extra work which is not required, or was there some reason of this?
- Why it's sending so much? in which frozen land you need to do a ping-pong every 1 second once it's trafficless or should be configurable at least.
- once we know connection is closed why we are waiting 30 seconds to dispatch close event, additionaly should be again in constant somewhere on start of file...
I could do PR with those changes but, want to be sure what is the reasons.