rollup/rollup-plugin-node-resolve

Strange code after upgrading up from v3.1.0

uNmAnNeR opened this issue · 3 comments

uNmAnNeR commented

Hello!

I use node-resolve-plugin in my project imaskjs for importing some core-js polyfills.

After upgrading plugin up from v3.1.0 some strange code with Object.freeze... appears:
compiled with v3.1.0
compiled with v3.3.0
diff
which increases compiled size.

Is it really needed?
No mistake here?

lukastaegert commented

Hi @uNmAnNeR, thanks for the issue. So you are saying the only dependency that changed is rollup-plugin-node-resolve, i.e. both builds use the exact same version of rollup? It would be very helpful if you could confirm this as this seems very related to the observations in rollup/rollup#2130

uNmAnNeR commented

@lukastaegert Yes, the only one.
So, previous builds were:
build rollup@0.58.1, node-resolve@3.1.0
build rollup@0.58.1, node-resolve@3.3.0

But lets do some more tests.
Rollback to:
build rollup@0.54.1, node-resolve@3.0.2
Update rollup:
build rollup@0.58.1, node-resolve@3.0.2
diff rollup 0.54.1->0.58.1
Than update node-resolve:
build rollup@0.58.1, node-resolve@3.3.0
diff node-resolve 3.0.2 -> 3.3.0

So in BOTH updates some new code with /*#__PURE__*/Object.freeze appeared!