get_historical() issues with dplyr in vignette
adamhsparks opened this issue · 12 comments
Perhaps related to #105?
adlmax <- get_historical(stationid = "023000", type = "max")
#> Error in get_historical(stationid = "023000", type = "max"): could not find function "get_historical"
adlmax
#> Error in eval(expr, envir, enclos): object 'adlmax' not found
adlmax %>%
select(station_number, year:day, max_temperature) %>%
filter(month == 10)
#> Error in adlmax %>% select(station_number, year:day, max_temperature) %>% : could not find function "%>%"Created on 2020-01-05 by the reprex package (v0.3.0)
I'm working on the devel branch right now.
Wait, I just realised, I have unmerged commits from master after I typed I was working on devel. Let me check that first.
Nope, still there after merging the master branch
Here's the Rmd where I first noted the issue.
I'll try to see what's going on but the first example looks like failure to document/export. The issue with select may be the same (not exported correctly).
I did find one of the @params wasn't documented in there I think and fixed that in the release I sent to CRAN last night. Working on a much larger release with new functionality right now so no hurry.
I just had to fix some tests that were causing failures on CRAN servers and had to get it pushed to CRAN by yesterday.
I've been looking at select() this AM. It's being exported as far as I can tell, it's in the NAMESPACE with all the other dplyr functions that are re-exported.
Still digging to see what I find.
This does work though.
adlmax %>%
bomrang::select(station_number, year:day, max_temperature)Fixed! Will push to devel shortly.
Fixed in 77ddd30
Is it clear what the issue was? I don't see any changes specific to select in that commit.
No, I'm not clear on what the issue was either. I'm with you. I didn't see any changes in NAMESPACE that fixed it, but it works now. Black magic?
Then let's never question it again, lest it break out of spite. Good work.