ropensci-archive/bomrang

BOM rainfall station list empty, leading to get_historical error

jimjam-slam opened this issue · 2 comments

jimjam-slam commented 
> get_historical(stationid = "023000", type = "max")
Error in x[i] : only 0's may be mixed with negative subscripts

Running debug(.get_ncc), it looks like this is a problem with lines 263-4 of get_historical.R: the list of rainfall stations published by the BOM is currently empty (I assume erroneously, because the temperature ones look fine), and because the resulting table parse attempt (starting line 230) ends up with less than 7 rows, line 264 crashes due to a subscripting error.

Bureau of Meteorology product IDCJMC0014.                                       Produced: 19 Aug 2020
Australian stations measuring rainfall

0 stations

(c) Copyright Commonwealth of Australia 2020, Bureau of Meteorology (ABN 92 637 533 532) 
Please note Copyright, Disclaimer and Privacy Notice, accessible at <http://www.bom.gov.au/other/copyright.shtml>

I daresay this will fix itself once things settle on the BOM's end, but I'll try to work on a PR to make the function more robust (particularly since this crash happens even if someone isn't looking for rainfall data) in the morning!

jimjam-slam commented

The rainfall station list for 20 August 2020 is also empty, so maybe this isn't going to dix itself 😔

adamhsparks commented
  • 😄1