Cherry-pick issue #42 fix to hydro and then release
shaun-edwards opened this issue · 5 comments
shaun-edwards commented
Issue #42 is a true bug. It should be back ported to the hydro release.
shaun-edwards commented
@Levi-Armstrong, I can help you through this. It will be good for you to learn how to do a release.
Levi-Armstrong commented
@shaun-edwards, I recently noticed that there is a rapid folder in the abb_common which was not addressed by the #42 fix; would like me to submit a pull request to fix this prior to fixing this issue?
shaun-edwards commented
Let's go ahead an fix it in abb_common
. We can then cherry-pick those two fixes into the hydro
branch.
Levi-Armstrong commented
@shaun-edwards, I have submitted PR #73 to fix the driver in abb_common, please review.
Levi-Armstrong commented
Addressed by PR #74