Cherry-pick issue #42 fix to hydro and then release

Question

Cherry-pick issue #42 fix to hydro and then release

shaun-edwards opened this issue 10 years ago · 5 comments

Issue #42 is a true bug. It should be back ported to the hydro release.

Answer 1 · 2015-03-03T22:47:16.000Z

@Levi-Armstrong, I can help you through this. It will be good for you to learn how to do a release.

Answer 2 · 2015-03-05T13:31:35.000Z

@shaun-edwards, I recently noticed that there is a rapid folder in the abb_common which was not addressed by the #42 fix; would like me to submit a pull request to fix this prior to fixing this issue?

Answer 3 · 2015-03-05T14:20:30.000Z

Let's go ahead an fix it in abb_common. We can then cherry-pick those two fixes into the hydro branch.

Answer 4 · 2015-03-05T19:00:37.000Z

@shaun-edwards, I have submitted PR #73 to fix the driver in abb_common, please review.

Answer 5 · 2015-03-21T15:37:03.000Z

Addressed by PR #74